Skip to content
This repository has been archived by the owner on Mar 14, 2018. It is now read-only.

Question regarding Observer's repeat method #289

Open
mrmin123 opened this issue Nov 21, 2017 · 1 comment
Open

Question regarding Observer's repeat method #289

mrmin123 opened this issue Nov 21, 2017 · 1 comment
Assignees

Comments

@mrmin123
Copy link

Hi RaiMan, I was wondering if there was a specific rationale behind why the Observer/OberserverEvent classes' repeat() takes a long instead of a float as a parameter.

The relevant code is in ObserverEvent and Observer.

It seems reasonable to want to repeat the next iteration of the observer in a fraction of a second and not just full seconds. Also, with the current code, calling repeat with 0 (event.repeat(0)) or no parameters (event.repeat()) defaults the wait to 1 second instead of 0, which I believe is the expect result.

For the record, I've worked around the issue of not being able to set a sub-1-second delay by overriding sikuli's settings: sikuli.Settings.RepeatWaitTime = 0 (default is 1) which actually results in the 0-second delay I was expecting.

I'm not sure what the ongoing support schedule is for 1.1.x but I wanted to bring this up in case it is an unintended behavior.

Thanks!

@RaiMan
Copy link
Owner

RaiMan commented Nov 26, 2017

Thanks for the pointer.
I will check and fix what is necessary in your sense with 1.1.2 nightly the next days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants