Add a refresh function to TutorialCoachMark and add unFocusAnimationDuration to TargetFocus #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BerkayOezSP
reviewed
Apr 27, 2022
| @@ -18,6 +18,7 @@ class TargetFocus { | |||
| this.alignSkip, | |||
| this.paddingFocus, | |||
| this.focusAnimationDuration, | |||
| this.unFocusAnimationDuration, | |||
There was a problem hiding this comment.
Its already in the newest version 1.2.2
There was a problem hiding this comment.
In 1.2.2, the unFocusAnimationDuration is only in TutorialCoachMark. I add it to the TargetFocus, so that the unFocusAnimationDuration can be adjust in each TargetFocus.
ReuelJosafa
added a commit
to ReuelJosafa/tutorial_coach_mark
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a refresh function to TutorialCoachMark
This can be called to update the position and size of the current target.
It can be called after the orientation changed
#66
Add unFocusAnimationDuration to TargetFocus
Customize unFocusAnimationDuration for each target.