Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent treatment of non-auto speed settings #98

Open
bettinardi opened this issue Sep 9, 2020 · 1 comment
Open

Inconsistent treatment of non-auto speed settings #98

bettinardi opened this issue Sep 9, 2020 · 1 comment

Comments

@bettinardi
Copy link
Collaborator

I’m seeing three areas of inconsistent treatment:

  1. Mode speeds in the config file - https://github.com/RSGInc/SOABM/blob/master/template/config/orramp.properties#L169 vs mode speed hard coded - https://github.com/RSGInc/SOABM/blob/master/template/scripts/SOABM.py#L324
  2. Related, this treatment assumes that the users has coded mode speeds correctly / consistently in Visum as well: https://github.com/RSGInc/SOABM/blob/master/template/scripts/SOABM.py#L356
  3. The wiki guidance does not seem correct on this page: https://github.com/RSGInc/SOABM/wiki/non-motorized-network-coding
@bettinardi
Copy link
Collaborator Author

The proposed solution for this issue is to change the createMazToTap function - https://github.com/RSGInc/SOABM/blob/master/template/scripts/SOABM.py#L319

This function should be changed to use distance instead of time. This would make the following wiki page correct - https://github.com/RSGInc/SOABM/wiki/non-motorized-network-coding

It would also remove the non-auto mode coded speed inconsistency. Taking out the speed coded in Visum and in the createMazToTap function, and leaving just the speed in the config file.

@bstabler and @binnympaul, is there any issue with this solution - of changing createMazToTap to use distance instead of time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant