Add RDAP Relation extension #1608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshryane
reviewed
Dec 17, 2024
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapObjectMapper.java
Outdated
Show resolved
Hide resolved
eshryane
reviewed
Dec 17, 2024
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapRelationService.java
Outdated
Show resolved
Hide resolved
eshryane
reviewed
Dec 17, 2024
whois-api/src/main/java/net/ripe/db/whois/api/rdap/domain/RelationType.java
Outdated
Show resolved
Hide resolved
eshryane
reviewed
Dec 17, 2024
whois-rpsl/src/main/java/net/ripe/db/whois/common/rpsl/attrs/InetnumStatus.java
Outdated
Show resolved
Hide resolved
eshryane
reviewed
Dec 17, 2024
whois-rpsl/src/main/java/net/ripe/db/whois/common/rpsl/attrs/Inet6numStatus.java
Outdated
Show resolved
Hide resolved
eshryane
reviewed
Dec 17, 2024
whois-commons/src/main/java/net/ripe/db/whois/common/etree/NestedIntervalMap.java
Outdated
Show resolved
Hide resolved
maggarwal13
reviewed
Jan 10, 2025
| @@ -183,6 +185,7 @@ public Object mapSearch(final String requestUrl, final List<RpslObject> objects, | |||
|
|
|||
| final RdapObject rdapObject = mapCommonNoticesAndPort(searchResult, requestUrl); | |||
| mapCommonLinks(rdapObject, requestUrl); | |||
| includeRirSearchConformance(rdapObject, requestUrl); | |||
| return mapCommonConformances(rdapObject); | |||
There was a problem hiding this comment.
This conformance should be included if it is a RIR search ?
There was a problem hiding this comment.
The Jira says
"Always return the "rirSearch1" extension on all responses."
There was a problem hiding this comment.
If that is the case we should add all conformance to every rdap response but we do not. For ex: we add geofeed Conformance only if it is Ip request . I think we need to be consistent about it. Let's discuss it with Ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing section 3, "Relation Searches" of RIR Search RFC:
https://www.ietf.org/id/draft-ietf-regext-rdap-rir-search-13.html