Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent usage of pnpm #70

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

iivvaannxx
Copy link
Contributor

This PR is quite small and self-explanatory. I was on my way to create a PR to fix #43 with Biome, and I noticed the presence of a package-lock.json. It does not do any harm in there (I think) but it may be confusing to other contributors to see multiple lock files of different package managers.

IMO it’s best to stick to only one package manager and use that to prevent any weird issues with dependencies having different versions in different environments due to different lockfiles.

I was going to add also this but maybe it’s a bit too much and according to this issue it’s buggy with npm.

@thejackshelton thejackshelton merged commit 9fe76e6 into QwikDev:main Mar 15, 2024
@iivvaannxx iivvaannxx deleted the use-only-pnpm branch March 15, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting and linting
2 participants