Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade fluent_ui usage to 3.6.0 because on Flutter >= 2.2.0 old fluent_ui 1.8.1 didn't compile anymore #2

Closed

Conversation

maxeema
Copy link

@maxeema maxeema commented Jan 20, 2022

Hello, team QuickBird!
*
Reference to the issue: #1
*
I will explain my PR. The problem occurred when I tried to run the "flutter_platform_search" demo app on the latest Flutter 2.8.1, as well as on the previous stable 2.5.3 and 2.2.0 releases. Because the Flutter API has been changed (as usual) at some moment, we couldn't run "flutter_platform_search" with the fluent_ui: ^1.8.1 dependency anymore. I tried fluent_ui version 1.9.+, it didn't help. In fluent_ui 2.+ and 3.+ were appeared new breaking changes in the API. So, the better way I found is to migrate the usage of the fluent_ui dependency to its latest version 3.6.0 and to update the WindowsSearchDelegate.buildScaffold() method to make the example compile and work on a fresh Flutter.

@maxeema maxeema changed the title fix: upgrade fluent_ui usage to 3.6.0 because on Flutter >= 2.8.1 old fluent_ui 1.8.1 didn't work anymore fix: upgrade fluent_ui usage to 3.6.0 because on Flutter >= 2.5.3 old fluent_ui 1.8.1 didn't work anymore Jan 21, 2022
@maxeema maxeema changed the title fix: upgrade fluent_ui usage to 3.6.0 because on Flutter >= 2.5.3 old fluent_ui 1.8.1 didn't work anymore fix: upgrade fluent_ui usage to 3.6.0 because on Flutter >= 2.2.0 old fluent_ui 1.8.1 didn't compile anymore Jan 21, 2022
@maxeema
Copy link
Author

maxeema commented Jan 21, 2022

Guys, I have finished fixes and the better PR to merge is #3

And I close this one.

@maxeema maxeema closed this Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant