-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ngi #1095
Open
leviathanch
wants to merge
22
commits into
Qucs:develop
Choose a base branch
from
leviathanch:ngi
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ngi #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are located in qucs/tests now
Trying to port tests from modular Qucs to develop Qucs. For now only testing whether loading schematics without crashing works, next will be to export the netlist from the schematics and see whether it's broken.
This reverts commit a093183.
Ported some reading writing tests from modular qucs to main develop qucs and introduced tests for reading schematics and writing out Verilog netlists. This is a preparation for testing how to write out schematics using Verilog.
Making the tests properly determine the current Qucs version and handing config.h generation properly within CMake
In order to test more effectively the functions for writing netlists and printing are being put in its separate .la library so that it can be directly used by the tests
BUG: connections are wrong, e.g. -Pac:P1 _net0 _net0 Num="1" Z="100 Ohm" P="0 dBm" f="1 GHz" Temp="26.85" -L:L1 _net1 _net1 L="1.2uH" I="" -L:L2 _net2 _net2 L="470nH" I="" -C:C1 _net3 _net3 C="270pF" V="" -C:C2 _net4 _net4 C="270pF" V="" -L:L3 _net5 _net5 L="470nH" I="" -.SP:SP1 Type="log" Start="1MHz" Stop="100MHz" Points="1001" Noise="no" NoiseIP="1" NoiseOP="2" saveCVs="no" saveAll="no" +Pac:P1 _net12 gnd Num="1" Z="100 Ohm" P="0 dBm" f="1 GHz" Temp="26.85" +L:L1 _net41 _net7 L="1.2uH" I="" +L:L2 _net7 _net5 L="470nH" I="" +C:C1 _net6 _net41 C="270pF" V="" +C:C2 _net8 _net7 C="270pF" V="" +L:L3 _net22 _net41 L="470nH" I=""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those patches introduce proper testing in Qucs:
Now it tests: