Small fixes #187
Open
Small fixes #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks that the RPC multiplexer only allows calls with 2 or 4 arguments and sets environment variables $QREXEC_REQUESTED_TARGET_TYPE, $QREXEC_REQUESTED_TARGET, and $QREXEC_REQUESTED_TARGET_KEYWORD properly. Since it only affects the tests, it can safely be backported to R4.2.
No functional change.
No other change.
No other functional change.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 79.17% 79.14% -0.03%
==========================================
Files 54 54
Lines 9953 10002 +49
==========================================
+ Hits 7880 7916 +36
- Misses 2073 2086 +13 ☔ View full report in Codecov by Sentry. |
This would result in malformed commands being generated.
This avoids option injection if an invalid VM name starting with '-' is passed.
These should never happen unless out of memory.
DemiMarie
force-pushed
the
small-fixes
branch
from
cbaed1e to
1878831
Compare
USB forwarding requires this, but there were no unit tests for it, so a buggy patch that broke it was not noticed until openQA tested USB forwarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all minor fixes that can be backported.