Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Example_6_Chinese_Attack URL #795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spidersouris
Copy link

What does this PR do?

Summary

This PR fixes the "Open in Colab" and "View source on GitHub" URLs on https://textattack.readthedocs.io/en/master/2notebook/Example_6_Chinese_Attack.html by replacing the final space with an underscore to match the correct file name.

Changes

  • Replaced the final space in the URLs with an undrscore

Checklist

  • The title of your pull request should be a summary of its contribution.
  • Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • To indicate a work in progress please mark it as a draft on Github.
  • Make sure existing tests pass.
  • Add relevant tests. No quality testing = no merge.
  • All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

Replaced final space with underscore
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiyanjun
Copy link
Member

@Hanyu-Liu-123 mind to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants