Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish dependencies and support python3.11 #780

Merged
merged 12 commits into from
Mar 10, 2024
Merged

Conversation

marcorosa
Copy link
Contributor

Summary

Hi, working on this project I noticed that some of the mandatory dependencies in requirements.txt are listed but are either not used or transitive dependencies. Moreover, some of them (pysocks and click) force old versions to be installed, without a clear reason.

Similarly, optional dependencies list tensorflow packages installation forcing an old version (~2 years old). This prevents new python versions to run this library. So, I propose to upgrade the version of tensorflow packages to be able to also support python 3.11 and 3.12

After my changes, I ran tests on ubuntu with python3.11 and they were all passing.

As a side note, please remember to update conf.py and release the new pypi package.

Changes

  • Allow recent versions of tensorflow as optional dependencies in setup.py
  • Deprecate unsupported python versions in setup.py

Deletions

  • Remove unnecessary dependencies from requirements.txt

@qiyanjun qiyanjun merged commit fce1f09 into QData:master Mar 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants