Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest errors - due to goal_func #748

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Fix pytest errors - due to goal_func #748

merged 2 commits into from
Sep 11, 2023

Conversation

qiyanjun
Copy link
Member

What does this PR do?

Fixing multiple pytest errors caused by one recent PR: pull request #709 from plasmashen/master #1435

Summary

reverse back to outputs.append(torch.tensor(batch_preds))
in e3d05c4

this fixed the pytest errors in running "textattack attack"

Checklist

  • [ x ] The title of your pull request should be a summary of its contribution.
  • [ x ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ ] To indicate a work in progress please mark it as a draft on Github.
  • Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

The errors were caused by the previous pull request
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiyanjun qiyanjun merged commit e426102 into master Sep 11, 2023
1 of 5 checks passed
@qiyanjun qiyanjun deleted the fix-pytest-errors branch September 11, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant