Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential bug in the filter_by_labels_ method of the Dataset class #746

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

wenh06
Copy link
Contributor

@wenh06 wenh06 commented Jul 17, 2023

What does this PR do?

Summary

This PR fixes Issue #745 .

Additions

NA

Changes

The last line of textattack.datasets.dataset.Dataset.filter_by_labels_ changed from

self._dataset = filter(lambda x: x[1] in labels_to_keep, self._dataset)

to

self._dataset = list(filter(lambda x: x[1] in labels_to_keep, self._dataset))

Deletions

NA

Checklist

  • [ ] The title of your pull request should be a summary of its contribution.
  • [ ] Please write detailed description of what parts have been newly added and what parts have been modified. Please also explain why certain changes were made.
  • [ ] If your pull request addresses an issue, please mention the issue number in the pull request description to make sure they are linked (and people consulting the issue know you are working on it)
  • [ ] To indicate a work in progress please mark it as a draft on Github.
  • [ ] Make sure existing tests pass.
  • [ ] Add relevant tests. No quality testing = no merge.
  • [ ] All public methods must have informative docstrings that work nicely with sphinx. For new modules/files, please add/modify the appropriate .rst file in TextAttack/docs/apidoc.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants