Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audit log filtering & sorting #2371

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: audit log filtering & sorting #2371

wants to merge 3 commits into from

Conversation

Lulalaby
Copy link
Member

Summary

This pull requests aims to remove the braindead logic for "sorting" audit logs.
We get the data already based on param combo.

Closes #2304

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lulalaby Lulalaby added bug Something isn't working help wanted Extra attention is needed priority: high High Priority API Reflection Discords API wasn't correctly reflected in the lib labels Feb 29, 2024
@Lulalaby Lulalaby added this to the v2.5 milestone Feb 29, 2024
@Lulalaby Lulalaby self-assigned this Feb 29, 2024
@Lulalaby Lulalaby modified the milestones: v2.5, v2.6 Feb 29, 2024
@Lulalaby
Copy link
Member Author

@Blue-Robin-Taken im not sure if that even works lmfao, did u tested?

Dorukyum
Dorukyum reviewed Feb 29, 2024
View reviewed changes
discord/iterators.py Outdated Show resolved Hide resolved
@Lulalaby
Update iterators.py
00d0dd8 
Signed-off-by: Lala Sabathil <[email protected]>
@Dorukyum Dorukyum removed the on hold label Mar 6, 2024
yoggys
yoggys approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@yoggys yoggys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and it works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum left review comments

@yoggys yoggys yoggys approved these changes

@Blue-Robin-Taken Blue-Robin-Taken Blue-Robin-Taken approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Lulalaby Lulalaby

Labels
API Reflection Discords API wasn't correctly reflected in the lib bug Something isn't working help wanted Extra attention is needed priority: high High Priority
Projects
Pycord Releases
Status: Todo
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

oldest_first=True in the audit logs returns newest_first
4 participants
@Lulalaby @Dorukyum @yoggys @Blue-Robin-Taken