Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actions): run jobs only for given targets #2032

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Lulalaby
Copy link
Member

@Lulalaby Lulalaby commented Apr 25, 2023

  • Most jobs will only run for pull requests when master is the target
  • All jobs can be run manually through workflow_dispatch
  • Jobs will check for paths. We don't always need to run everything, especially when updates are made to i.e. README.md

@Lulalaby
Copy link
Member Author

TODO for bob:

  • Update branch protection rules to skip requirements if action isn't supposed to run

@Lulalaby
Copy link
Member Author

Alternative, report as success if path not hit

@JustaSqu1d JustaSqu1d added the github_actions Pull requests that update GitHub Actions code label May 1, 2023
@Lulalaby Lulalaby force-pushed the lala-cleanup/actions/rework branch from 10f86d2 to a4f480b Compare May 3, 2023 12:50
@Lulalaby Lulalaby marked this pull request as ready for review June 13, 2023 21:56
@Lulalaby Lulalaby requested a review from a team as a code owner June 13, 2023 21:56
@pullapprove4 pullapprove4 bot requested a review from Middledot June 13, 2023 21:56
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #2032 (a9db368) into master (297053d) will decrease coverage by 0.74%.
The diff coverage is n/a.

❗ Current head a9db368 differs from pull request most recent head dcd1037. Consider uploading reports for the commit dcd1037 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
- Coverage   33.86%   33.13%   -0.74%     
==========================================
  Files         109       97      -12     
  Lines       22367    19141    -3226     
==========================================
- Hits         7575     6342    -1233     
+ Misses      14792    12799    -1993     
Flag Coverage Δ
macos-latest-3.10 33.11% <ø> (-0.73%) ⬇️
macos-latest-3.11 33.11% <ø> (-0.73%) ⬇️
macos-latest-3.8 33.12% <ø> (-0.73%) ⬇️
macos-latest-3.9 33.12% <ø> (-0.73%) ⬇️
ubuntu-latest-3.10 33.11% <ø> (-0.73%) ⬇️
ubuntu-latest-3.11 33.11% <ø> (-0.73%) ⬇️
ubuntu-latest-3.8 33.12% <ø> (-0.73%) ⬇️
ubuntu-latest-3.9 33.12% <ø> (-0.73%) ⬇️
windows-latest-3.10 33.11% <ø> (-0.73%) ⬇️
windows-latest-3.11 33.11% <ø> (-0.73%) ⬇️
windows-latest-3.8 33.12% <ø> (-0.73%) ⬇️
windows-latest-3.9 33.12% <ø> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2a0d8...dcd1037. Read the comment docs.

@Dorukyum Dorukyum changed the title chore(actions): run jobs only for given targets to avoid spam chore(actions): run jobs only for given targets Jan 21, 2024
@Lulalaby Lulalaby added this to the v2.6 milestone Feb 28, 2024
@Dorukyum Dorukyum removed the on hold label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants