Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext.pages): Add ButtonTypes presets for paginator buttons #1818

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Nzii3
Copy link
Contributor

@Nzii3 Nzii3 commented Dec 3, 2022

Summary

Adds a ButtonTypes class that allows users to use preset paginator button styles easily.

THIS PR IS STILL NOT FINISHED!

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Nzii3 Nzii3 requested a review from a team as a code owner December 3, 2022 21:04
@Nzii3 Nzii3 self-assigned this Dec 3, 2022
@Nzii3 Nzii3 added ext.pages Relating to ext.pages status: in progress Work in Progess labels Dec 3, 2022
@Nzii3 Nzii3 requested a review from BobDotCom December 3, 2022 22:06
@Lulalaby
Copy link
Member

Lulalaby commented Dec 4, 2022

Isn't that a dup of #1811 ?

Couldn't that be done in scope of that pr?

@EmreTech

This comment was marked as outdated.

@EmreTech
Copy link
Contributor

EmreTech commented Dec 4, 2022

Misread, sorry.

@Nzii3
Copy link
Contributor Author

Nzii3 commented Dec 4, 2022

Isn't that a dup of #1811 ?

Couldn't that be done in scope of that pr?

@Lulalaby I think Bob wanted a separate thing but they are similar. Context

@Nzii3
Copy link
Contributor Author

Nzii3 commented Dec 4, 2022

I could add it into that pr tho

@BobDotCom BobDotCom marked this pull request as draft December 6, 2022 16:08
@BobDotCom
Copy link
Member

status?

@Nzii3
Copy link
Contributor Author

Nzii3 commented Jan 6, 2023

status?

Sorry, not done yet. Been kinda busy with other projects. I’ll work on it this weekend.

@Nzii3 Nzii3 marked this pull request as ready for review January 9, 2023 17:39
Co-authored-by: BobDotCom <[email protected]>
Signed-off-by: Nziie3 <[email protected]>
@BobDotCom
Copy link
Member

Could you add a way to pass in the ButtonTypes class into a classmethod constructor (or as a param in the init constructor) for the paginator? The use_styled_buttons/use_default_buttons params should also access the ButtonTypes class.

@Nzii3
Copy link
Contributor Author

Nzii3 commented Jan 10, 2023

Could you add a way to pass in the ButtonTypes class into a classmethod constructor (or as a param in the init constructor) for the paginator? The use_styled_buttons/use_default_buttons params should also access the ButtonTypes class.

Will do.

@BobDotCom
Copy link
Member

status update?

@Nzii3
Copy link
Contributor Author

Nzii3 commented Feb 14, 2023

Been busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

6 participants