Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: PS2 / PPSSPP / AppIcon Fixes to pass all compile workflow checks #2337

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

rf2222222
Copy link
Contributor

@rf2222222 rf2222222 commented May 6, 2024

What does this PR do

Fixes PS2 paths to relative path
Fixes PPSSPP to compile on AppleTV (needs Apple TV MoltenVK to work on AppleTV)
Fixes AppIcon sizes to individual sizes (so it compiles on Azure Xcode 14.1)

Where should the reviewer start

How should this be manually tested

Any background context you want to provide

What are the relevant tickets

Screenshots (important for UI changes)

Questions

@rf2222222 rf2222222 force-pushed the rf2222222-emuthreeRebirth branch 4 times, most recently from 5faafec to 3e4ee21 Compare May 6, 2024 20:33
@rf2222222 rf2222222 changed the base branch from rf2222222-emuthreeRebirth to develop May 7, 2024 06:19
@rf2222222 rf2222222 force-pushed the rf2222222-emuthreeRebirth branch 2 times, most recently from f867431 to df44342 Compare May 7, 2024 07:00
Copy link

github-actions bot commented May 7, 2024

Builds for this Pull Request are available at
Provenance-Lite.ipa
ProvenanceTV.ipa
Provenance-tvOS.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

Copy link

github-actions bot commented May 7, 2024

Builds for this Pull Request are available at
Provenance-Lite.ipa
ProvenanceTV.ipa
Provenance-tvOS.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@rf2222222 rf2222222 force-pushed the rf2222222-emuthreeRebirth branch 2 times, most recently from 7277a99 to 4c2aa5f Compare May 7, 2024 12:17
Copy link

github-actions bot commented May 7, 2024

Builds for this Pull Request are available at
Provenance-Lite.ipa
ProvenanceTV.ipa
Provenance-tvOS.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@rf2222222 rf2222222 force-pushed the rf2222222-emuthreeRebirth branch 5 times, most recently from 6881812 to c0742c0 Compare May 7, 2024 22:12
@JoeMatt JoeMatt marked this pull request as draft May 8, 2024 04:15
@JoeMatt
Copy link
Member

JoeMatt commented May 8, 2024

I see this has active pushes still so I converted to a draft PR.

Does this PR override the need for #2334 ?

@rf2222222
Copy link
Contributor Author

rf2222222 commented May 8, 2024

I see this has active pushes still so I converted to a draft PR.

Does this PR override the need for #2334 ?

This adds code to get PPSSPP to compile on Apple TV (so Provenance Project compiles on build tests using appletvos), and for Play to compile on iOS (updates the hardcoded paths), on top of 2334. So.. this could just be pointed to merge into 2334, or it could be overridden — it’s up to you. =]

These are essentially fixes to get all the build checks to pass.

AppIcon in Assets using Single Size (the 1024x1024 image) was throwing an error, which is fixed by specifying individual sizes. A script to auto generate various sizes of icons on iOS/watchOS is added, along with different sizes in Contents.json inside AppIcon. With this, everything should now compile on all tests.

Copy link

github-actions bot commented May 8, 2024

Builds for this Pull Request are available at
Provenance-Lite.ipa
ProvenanceTV.ipa
Provenance-tvOS.ipa
Provenance-UnderDevelopment.ipa
Provenance-XL.ipa
Have a nice day.

@rf2222222 rf2222222 marked this pull request as ready for review May 8, 2024 12:37
@rf2222222 rf2222222 changed the title PS2: Fix Paths Build: PS2 / PPSSPP / AppIcon Fixes to pass all compile workflow checks May 8, 2024
@JoeMatt
Copy link
Member

JoeMatt commented May 10, 2024

I see this has active pushes still so I converted to a draft PR.
Does this PR override the need for #2334 ?

This adds code to get PPSSPP to compile on Apple TV (so Provenance Project compiles on build tests using appletvos), and for Play to compile on iOS (updates the hardcoded paths), on top of 2334. So.. this could just be pointed to merge into 2334, or it could be overridden — it’s up to you. =]

These are essentially fixes to get all the build checks to pass.

AppIcon in Assets using Single Size (the 1024x1024 image) was throwing an error, which is fixed by specifying individual sizes. A script to auto generate various sizes of icons on iOS/watchOS is added, along with different sizes in Contents.json inside AppIcon. With this, everything should now compile on all tests.

bro, you rule.

I can't express enough how f'ing cool it is for you to put this much effort into these PRs.

@JoeMatt
Copy link
Member

JoeMatt commented May 10, 2024

Just so you know, I changed the code sign for the sub-core frameworks because MacOS catalyst wouldn't work without it.

This may be a bug, though, in the current XCode. I ran across a script the other day to fix the issue at build and sign time on a completely unrelated github issue I found.

I don't remember where it was, though. I'll merge this PR as is, but I may temporarily have to revert back to the code signing for those modules or use an XCconfig file to make it easy for others.

At this moment, I have to focus my energy on making it app store and cross-platform friendly since that's where the support for the project is, and that's what allows me to focus my time on the app again.

Hit me up on Discord if you have it, or let me know how else we can talk one-on-one because I'd love to be able to help support your work through the support that Provenance has recently seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants