Pin Conan revisions correctly #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjjbell
force-pushed
the
mbell/fix_build
branch
from
8f24ba5
to
aeab91b
Compare
mjjbell
changed the title
mjjbell
force-pushed
the
mbell/fix_build
branch
3 times, most recently
from
4b6ccf6
to
ad31cb8
Compare
Conan dependencies are not pinned correctly. This means we're pulling in a newer onetbb recipe that no longer has a shared library option. Following other examples of how to pin revisions with cmake for conan v1, we correctly pin the expected revisions. Longer term we should look into - upgrading to conan v2 - defining the conan config separately from cmakelists.txt - understanding the need for disabling onetbb shared library support but for the purposes of reviving CI, this will be sufficient.
mjjbell
force-pushed
the
mbell/fix_build
branch
5 times, most recently
from
a2752aa
to
7eb583f
Compare
mjjbell
force-pushed
the
mbell/fix_build
branch
from
7eb583f
to
76c28a9
Compare
DennisOSRM
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Conan dependencies are not pinned correctly. This means we're pulling in a newer onetbb recipe that no longer has a shared library option.
Following other examples of how to pin revisions with cmake for conan v1, we correctly pin the expected revisions.
Longer term we should look into
but for the purposes of reviving CI, this will be sufficient.
Requirements / Relations
Help to restore the project as discussed in #6778