Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Disable deployments #2645

Merged
merged 10 commits into from
Aug 13, 2024
Merged

Conversation

dylanbhughes
Copy link
Contributor

@dylanbhughes dylanbhughes commented Aug 5, 2024

Closes #2594

@dylanbhughes dylanbhughes marked this pull request as ready for review August 12, 2024 22:08
@dylanbhughes dylanbhughes requested a review from a team as a code owner August 12, 2024 22:08
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but nothing blocking

@@ -30,7 +31,18 @@
<div v-for="automation in relatedAutomations" :key="automation.id" class="deployment-details-triggers__value">
<AutomationIconText :automation-id="automation.id" />
</div>

<!-- If the button has a :to set, it doesn't seem to respect the :disabled param -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a bug we can solve, opened a ticket here

src/components/DeploymentDetails.vue Show resolved Hide resolved
src/components/DeploymentDisableToggle.vue Outdated Show resolved Hide resolved
src/components/DeploymentList.vue Show resolved Hide resolved
src/components/DeploymentStatusIcon.vue Outdated Show resolved Hide resolved
src/components/RunMenu.vue Show resolved Hide resolved
@dylanbhughes dylanbhughes merged commit 68409c6 into main Aug 13, 2024
2 checks passed
@dylanbhughes dylanbhughes deleted the enhancement/disable-deployments branch August 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toggles for new Deployment property: "disabled"
2 participants