Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add layout and hide edges options to timeline #1135

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

brandonreid
Copy link
Contributor

@brandonreid brandonreid commented Feb 9, 2023

Users with large flow runs have reported issues with the timeline slowing down the Flow Run page.

In addition to the latest graphs update having some rendering optimizations, this introduces a couple options for faster/lighter rendering of the timeline:

Screenshot 2023-02-09 at 7 43 43 AM

Layout options

  • Nearest Parent - default
  • Waterfall - this is how the timeline used to render nodes, it's much faster to calculate and will be set as the default layout if the flow run has more than the threshold number of nodes (currently set to 100)

Hide Edges option

Edges are more expensive to render since the paths are all one-off graphics currently, so this option let's you skip rendering them and is automatically set to true if the flow run has more than the threshold number of nodes (currently set to 40). Note that edge paths for selected nodes and their dependencies will still show.

@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for orion-design ready!

Name Link
🔨 Latest commit 84015dc
🔍 Latest deploy log https://app.netlify.com/sites/orion-design/deploys/63e52e6df8b3e20008d3949f
😎 Deploy Preview https://deploy-preview-1135--orion-design.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/components/FlowRunTimelineOptions.vue Show resolved Hide resolved
src/components/FlowRunTimelineOptions.vue Show resolved Hide resolved
src/components/FlowRunTimelineOptions.vue Outdated Show resolved Hide resolved
src/components/FlowRunTimelineOptions.vue Outdated Show resolved Hide resolved
src/components/FlowRunTimelineOptions.vue Outdated Show resolved Hide resolved
@brandonreid brandonreid requested a review from pleek91 February 9, 2023 17:34
@brandonreid brandonreid merged commit 040bf86 into main Feb 9, 2023
@brandonreid brandonreid deleted the feature/flow-run-timeline-options branch February 9, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants