Skip to content

Commit

Permalink
resolve peer review
Browse files Browse the repository at this point in the history
  • Loading branch information
brandonreid committed Feb 9, 2023
1 parent 09ac3c0 commit 84015dc
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions src/components/FlowRunTimelineOptions.vue
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
<template>
<p-pop-over
ref="popOver"
class="flow-run-timeline-options"
auto-close
:placement="placement"
>
<template #target="{ toggle }">
<p-button
ref="settingsButton"
aria-label="Flow Run Timeline Options"
icon="CogIcon"
flat
Expand All @@ -34,7 +32,7 @@
<script lang="ts" setup>
import { TimelineNodesLayoutOptions } from '@prefecthq/graphs'
import { PButton, positions, PPopOver } from '@prefecthq/prefect-design'
import { computed, ref } from 'vue'
import { computed } from 'vue'
const props = defineProps<{
layout: TimelineNodesLayoutOptions,
Expand All @@ -46,8 +44,6 @@
(event: 'update:hideEdges', value: boolean): void,
}>()
const settingsButton = ref<typeof PButton>()
const popOver = ref<typeof PPopOver>()
const placement = [positions.topRight, positions.bottomRight, positions.topLeft, positions.bottomLeft]
const layoutOptions: {
Expand All @@ -64,7 +60,7 @@
]
const layoutModel = computed({
get: () => props.layout,
set: (layout: TimelineNodesLayoutOptions) => emit('update:layout', layout),
set: (layout) => emit('update:layout', layout),
})
const hideDependencyArrowsModel = computed({
Expand All @@ -85,7 +81,4 @@
.flow-run-timeline-options__popover-option-set { @apply
p-3
}
.flow-run-timeline-options__popover-option-set label { @apply
cursor-pointer
}
</style>

0 comments on commit 84015dc

Please sign in to comment.