feat(prefect-server): support sqlite database #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports using sqlite for the database in place of postgresql. Closes https://linear.app/prefect/issue/PLA-139/support-sqlite-database
- HPA is not desired given that sqlite requires 1 replica - secret is postgresql-specific
This test, separate from my changes, failed because it was looking for a volumeMount at a specific index. This change allows it to just confirm the entry is present without worrying about a specific location in the list.
The application was failing to start, saying it couldn't access the database file. This change mounts a directory without a subPath setting, allowing the application to create the file instead.
Uses a template to calculate the PVC name, matching the pattern used for other objects like the Deployment.
mitchnielsen
force-pushed
the
support-sqlite
branch
from
1f3dee9 to
51e0515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supports using SQLite for the database in place of PostgreSQL.
Closes https://linear.app/prefect/issue/PLA-139/support-sqlite-database
Closes #345
Testing
First, check out the the unit tests added for confirming general functionality.
For a functional test:
prefect-serverchart (confirming that no PostgreSQL Pod is deployed)