Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seccompProfile as valid podSecurityContext property #375

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add seccompProfile as valid podSecurityContext property #375

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4736e59
Add seccompProfile as valid podSecurityContext property
dk-oc Aug 27, 2024
516ee95
Merge branch 'main' into patch-1
dk-oc Oct 7, 2024
3114a20
Merge branch 'main' into patch-1
jamiezieziula Oct 8, 2024
f157e04
Merge branch 'main' into patch-1
dk-oc Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions charts/prefect-server/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,16 @@
"type": "integer",
"title": "FS Group",
"description": "set server pod's security context fsGroup"
},
"seccompProfile": {
"type": "object",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is additionalProperties defaulting to true here (eg. if you need to pass localhostProfile)? or do we need to explicitly set it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dk-oc - just following up here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed the notification.
As far as I understand it defaults to true if a podSecurityContext is set.
I use a values.yml as such and can deploy the chart in the restricted environment I am running

server:
  containerSecurityContext:
    capabilities:
      drop: ["ALL"]
  podSecurityContext:
    seccompProfile:
      type: RuntimeDefault

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dk-oc - I believe the question was more about what happens if you set type: Localhost, as that one requires an extra field to be set named localhostProfile:

securityContext:
  seccompProfile:
    type: Localhost
    localhostProfile: my-profiles/profile-allow.json

We'd need to either set additionalProperties here, or explicitly define the localhostProfile

"properties": {
"type": {
"type": "string",
"enum": ["RuntimeDefault", "Localhost"]
}
},
"required": ["type"]
}
}
},
Expand Down