fix: Bad PrometheusRule annotations for server down #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchnielsen
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks for catching this @TheBeege, just one small suggestion!
Updated alert description per @mitchnielsen's advice Co-authored-by: Mitchell Nielsen <[email protected]>
Thanks for the suggestion! Updated |
mitchnielsen
approved these changes
Aug 22, 2024
|
Thanks again @TheBeege 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested
PrometheusRuleannotations for the server down alert were copied from the flow run crashed or failed alert. This rewrites the annotations to be more accurate.Let me know if you'd prefer a different wording.