Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Add global param #260

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix/Add global param #260

merged 1 commit into from
Oct 18, 2023

Conversation

jimid27
Copy link
Contributor

@jimid27 jimid27 commented Oct 18, 2023

  • All subcharts and charts can access a "global" values type (info here) so adding this addition to fix the failures that have been reported when using subcharts.
    Verified functionality locally.
  • Resolves: Ignore values.schema.json ? #258

@jimid27 jimid27 requested a review from a team as a code owner October 18, 2023 19:24
@jimid27 jimid27 merged commit bddc3f2 into main Oct 18, 2023
6 checks passed
@jimid27 jimid27 deleted the chore/add-allowed-global-param branch October 18, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiezieziula jamiezieziula jamiezieziula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore values.schema.json ?
2 participants
@jimid27 @jamiezieziula