Update environment variables passed to the prefect server chart
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
reviewed
Oct 16, 2023
jamiezieziula
changed the title
PUBLIC_UI_URL on the server chartserver chart
jamiezieziula
added
breaking
and removed
enhancement
jamiezieziula
commented
Oct 16, 2023
Comment on lines
-67
to
-70
| - --host | ||
| - 0.0.0.0 | ||
| - --log-level | ||
| - WARNING |
There was a problem hiding this comment.
these values aren't changing, but are properly exposed to the end user now.
jamiezieziula
commented
Oct 16, 2023
Comment on lines
+78
to
+84
| value: {{ .Values.server.debug | quote }} | ||
| - name: PREFECT_LOGGING_SERVER_LEVEL | ||
| value: {{ .Values.server.loggingLevel | quote }} | ||
| - name: PREFECT_SERVER_API_HOST | ||
| value: {{ .Values.server.prefectApiHost | quote }} | ||
| - name: PREFECT_SERVER_API_PORT | ||
| value: {{ .Values.service.targetPort | quote }} |
There was a problem hiding this comment.
these were already being inferred or set elsewhere, so explicitly setting them here now
jamiezieziula
commented
Oct 16, 2023
Comment on lines
+85
to
+86
| - name: PREFECT_UI_ENABLED | ||
| value: {{ .Values.server.uiConfig.enabled | quote }} |
There was a problem hiding this comment.
same thing here, this is the default behavior
jamiezieziula
commented
Oct 16, 2023
Comment on lines
+75
to
+76
| - name: PREFECT_API_URL | ||
| value: {{ .Values.server.prefectApiUrl | quote }} |
There was a problem hiding this comment.
we were not previously setting this, which was incorrect behavior. All other URLs are inferred from this, so it needs to be set.
jamiezieziula
commented
Oct 16, 2023
Comment on lines
+87
to
+93
| {{- if .Values.server.uiConfig.prefectUiApiUrl }} | ||
| - name: PREFECT_UI_API_URL | ||
| value: {{ .Values.server.publicApiUrl | quote }} | ||
| value: {{ .Values.server.uiConfig.prefectUiApiUrl | quote }} | ||
| {{- end }} | ||
| {{- if .Values.server.uiConfig.prefectUiUrl }} | ||
| - name: PREFECT_UI_URL | ||
| value: {{ .Values.server.uiConfig.prefectUiUrl | quote }} |
There was a problem hiding this comment.
these values are only necessary if the endpoint for the UI is different than the URL set in the prefectApiUrl parameter
parkedwards
approved these changes
Oct 16, 2023
jakekaplan
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implement a breaking change. The following will need to be updated in the end users environment when upgrading:
Prefect API URL (server.prefectApiUrl)
This value was previously not exposed. It is set to default value that was previously set at
server.publicApiUrl. If the URL of your server installation is nothttp://localhost:4200, you will need to override that value here.Prefect UI Configuration
Unless you have a different endpoint for your UI server, you can ignore this change. If your UI endpoint is unique from the API endpoint, you will need to set both
server.uiConfig.prefectUiApiUrlandserver.uiConfig.prefectUiUrl.Debug Level
If you previously had
server.image.debugset totrue, you will need to remove that setting and instead setserver.debugto betrueSee here for any questions around the possible server environment variables