fix(Youtube Music): timestamp fix

[ION606]

Description

• Fixed the issue where the start timestamp would malfunction when changing from use time left mode.

This issue was caused due to the getTimestamps function, which for SOME REASON completely ignores the first parameter in favor of using Date.now()

possibly resolves #8131

Acknowledgements

• I read the Presence Guidelines
• I linted the code by running yarn format
• The PR title follows the repo's commit conventions

Screenshots

Proof showing the creation/modification is working as expected

[veryCrunchy]

Fixed in alpha/beta

[ION606]

this PR deals with when the timestamp is updated (i.e. on seek), check the code on the first commit pls

[veryCrunchy]

Please try the alpha/beta, this doesn't seem to be an actual issue

[veryCrunchy]

I think you're better off removing the useTimeLeft toggle fully.
You're introducing more bugs for elapsed right now than that you are fixing.
Having the time left is the preferred behaviour anyway.

[ION606]

I suppose, but also, check this pull and the corresponding issue #8324

[ION606]

odd, I thought I removed that part, my fix was the toggle and the additional call on seek

[veryCrunchy]

If you want to have the actual elapsed time of the song you'll have to calculate the songs timestamps.
The Date.now() isn't doing much now.
Also please remove and don't set the event listeners if privacy mode is enabled.
And move all updateSongTimestamps calls behind the privacy mode statement.

[ION606]

If you want to have the actual elapsed time of the song you'll have to calculate the songs timestamps. The Date.now() isn't doing much now. Also please remove and don't set the event listeners if privacy mode is enabled. And move all updateSongTimestamps calls behind the privacy mode statement.

wait where do I set event listeners, like

if (useTimeLeftChanged !== useTimeLeft && !privacyMode) {
		useTimeLeftChanged = useTimeLeft;
		updateSongTimestamps(useTimeLeft);
	}

[veryCrunchy]

Is useTimeLeftChanged really necessary?

[ION606]

Is useTimeLeftChanged really necessary?

yes, it helps avoid redundant calls

[veryCrunchy]

Looks good then
@theusaf (I can't request reviews ;-;)