Allow module without version #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteveL-MSFT I know you have a ton on your plate, but hopefully you have some time to check out this small change. If you want me to add a test, I can make a duplicate of the TestClassResource. Thanks. |
|
Tests have been included. If you need it in the config, let me know, thought I don't believe it is needed. |
SteveL-MSFT
reviewed
Nov 27, 2024
| $containsDSCResource = select-string -LiteralPath $psd1 -pattern '^[^#]*\bDscResourcesToExport\b.*' | ||
| if($null -ne $containsDSCResource) | ||
| { | ||
| $moduleFolders = Get-ChildItem $folder -Directory |
There was a problem hiding this comment.
What's not clear to me is why the original code didn't just use Get-Module -ListAvailable instead of parsing PSModulePath and replicating some of that logic. @anmenaga ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Allow modules that don't have a version directory to be added in
$env:PSModulePath.PR Context
The
Get-DscResourceModulesfunction scans the$env:PSModulePathto find relevant modules to be included in the cache. When a module doesn't have a version directory, it does not find the module. This change allows the ability to include modules that don't contain the directory.I added this change because it can be useful for testing purposes to see the participation of DSC resources when developing them. For example, take the
winget-dscrepository. Simply adding the resource to the environment variable adds it for participation.