rec: Only log MOADNSExceptions if logging.log_common_errors is true. #14611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But do not ratelimit them. Note that
MOADNSExceptions
is derived fromstd::runtime_errror
and not fromstd::exception
.Also introduce the same logic related to
gettag()
inrec-tcp.cc
compared topdns_recursor.cc
.Churn is a bit high as
s_rateLimitedLogger
changed intog_rateLimitedLogger
, to make it available inrec-tcp.cc
.Fixes #14582
Short description
Checklist
I have: