Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed compression for node runtime since its buffering the response during streaming #309

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

mohankumarelec
Copy link
Contributor

Title:

  • Removed compression for node runtime since its buffering the response during streaming

Description:

  • Removed compression middleware if runtime is node
  • Removed content-encoding header to disabled compression for node

Motivation:

  • Adding compression middleware buffers the response while streaming, defeating the purpose of streaming

Related Issues:

@flexchar
Copy link
Contributor

Actually I am using image where I also disable it. I would propose completely removing it. The benefit is less than the pain it can cause, and in the context of streaming it's not giving much anyways.

Copy link

@arbi-dev arbi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Streaming is very important, please implement this or another fix.

@VisargD
Copy link
Collaborator

VisargD commented May 20, 2024

Hey all. I will verify and merge these changes. Thanks for the PR!

@roh26it roh26it requested review from roh26it and VisargD July 5, 2024 06:18
@roh26it
Copy link
Collaborator

roh26it commented Jul 5, 2024

@VisargD have we made more changes after this?

@frunkp
Copy link

frunkp commented Jul 25, 2024

@VisargD Can you merge that PR, pretty please 🙏?

@VisargD VisargD merged commit 0261777 into Portkey-AI:main Jul 25, 2024
1 check passed
@VisargD
Copy link
Collaborator

VisargD commented Jul 25, 2024

@frunkp - Merged the PR. Sorry for the delay on this.

@frunkp
Copy link

frunkp commented Jul 25, 2024

Thank you! Any plans to release v1.5.4 soon?

@VisargD
Copy link
Collaborator

VisargD commented Jul 26, 2024

Released v1.5.5 which has this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants