Revert "Capitalise rather than uppercase titles" #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit efae240. This resolves issue PolicyEngine#704 where parameter labels containing acronyms in all capital letters were being forced into proper case.
MaxGhenis
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit efae240. This resolves #704 where parameter labels containing acronyms in all capital letters were being forced into proper case.
🤖 Generated by Copilot at da7752f
Summary
🗑️🚫🛑
Fixed a bug that caused some parameter labels to lose their capitalization in the policy input editor. Removed an unnecessary
toLowerCase()method call fromParameterEditor.jsx.Walkthrough
toLowerCase()method from parameter labels to preserve original case (link)