Auth now specifies api as audience. #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially fixes #2263 In the baseline implementation of the app the auth token request did not specify an audience (the target API for the JWT). After defining the policyengine API in auth0, I have now updated both the provider and the fetch with auth to specify issuer. Immediately this will actually stop existing, logged in users from submitting a bearer token until they have to re-log in. Since the bearer token is yet used this change will not impact the user experience.
MaxGhenis
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes #2263
In the baseline implementation of the app the auth token request did not specify an audience (the target API for the JWT). After defining the policyengine API in auth0, I have now updated both the provider and the fetch with auth to specify issuer.
Immediately this will actually stop existing, logged in users from submitting a bearer token until they have to re-log in.
Since the bearer token is yet used this change will not impact the user experience.