Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale action for issues #4198

Closed

Conversation

Andre601
Copy link
Collaborator

Adds actions/stale for handling stale issues.

I've included it in the workflow file containing the lock action.
I also disabled (commented out) the lock action, as it seems to encounter rate limits (Probs bad rate limit handling on the action's end?).

May re-enable it later, or see if a lock option can be implemented to the stale action itself. Issue for that can be tracked here: actions/stale#1188

Copy link
Collaborator

@LoneDev6 LoneDev6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be changed to this.
Basically no message to avoid useless notifications. In some cases I might be the one ignoring issues to prioritize others and I don't want people to get notified about that.
Also I disabled automatic close.
What do you think?

name: 'Lock Threads'

on:
  schedule:
    - cron: '0 5 * * *'
  workflow_dispatch:

permissions:
  issues: write
  pull-requests: write
  discussions: write

concurrency:
  group: lock-threads

jobs:
  label-inactive-issues:
    runs-on: ubuntu-latest
    steps:
      - name: "Checkout Repository"
        uses: actions/checkout@v4
      - name: "Label inactive Issues"
        uses: actions/stale@v8
        with:
          repo-token: ${{ secrets.GITHUB_TOKEN }}
          stale-issue-label: "status: inactive"
          days-before-stale: 90
          days-before-close: -1
          days-before-pr-stale: -1 # Ignore Pull requests

@Andre601
Copy link
Collaborator Author

Idk... Having issues marked as stale without anything else seems pointless in the end. Especially if nobody is even aware it became stale.
Because in that case can we just not have the action to begin with. Would be basically the same result.

@Andre601
Copy link
Collaborator Author

Andre601 commented Dec 2, 2024

I implemented your requested changes.
I personally am not a fan of this, but at the end is it not my decision to make here. Only thing left is have the label made before merge (unless the action would create it which afaik is not the case)

@TheGiraffe3
Copy link

That is correct. The label will not automatically be created.

@LoneDev6 LoneDev6 closed this Dec 6, 2024
@Andre601 Andre601 deleted the feature/add-stale-issues-action branch December 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants