Skip to content

Commit

Permalink
✨ use input instead of env to receive github token
Browse files Browse the repository at this point in the history
Co-authored-by: Platane <[email protected]>
  • Loading branch information
Awayume and Platane committed Oct 17, 2023
1 parent 01fa6d7 commit c9644d3
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 14 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ jobs:
dist/github-contribution-grid-snake.svg
dist/github-contribution-grid-snake-dark.svg?palette=github-dark
dist/github-contribution-grid-snake.gif?color_snake=orange&color_dots=#bfd6f6,#8dbdff,#64a1f4,#4b91f1,#3c7dd9
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: ensure the generated file exists
run: |
Expand Down Expand Up @@ -79,8 +77,6 @@ jobs:
outputs: |
dist/github-contribution-grid-snake.svg
dist/github-contribution-grid-snake-dark.svg?palette=github-dark
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: ensure the generated file exists
run: |
Expand Down
4 changes: 4 additions & 0 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ inputs:
github_user_name:
description: "github user name"
required: true
github_token:
description: "github token used to fetch the contribution calendar. Default to the action token if empty."
required: false
default: ${{ github.token }}
outputs:
required: false
default: null
Expand Down
3 changes: 2 additions & 1 deletion packages/action/__tests__/generateContributionSnake.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as fs from "fs";
import * as path from "path";
import * as core from "@actions/core";
import { generateContributionSnake } from "../generateContributionSnake";
import { parseOutputsOption } from "../outputsOptions";
import { config } from "dotenv";
Expand Down Expand Up @@ -33,7 +34,7 @@ it(
const outputs = parseOutputsOption(entries);

const results = await generateContributionSnake("platane", outputs, {
githubToken: process.env.GITHUB_TOKEN!,
githubToken: core.getInput("github_token"),
});

expect(results[0]).toBeDefined();
Expand Down
3 changes: 2 additions & 1 deletion packages/action/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import { parseOutputsOption } from "./outputsOptions";
core.getInput("svg_out_path"),
]
);
const githubToken = process.env.GITHUB_TOKEN!;
const githubToken =
process.env.GITHUB_TOKEN ?? core.getInput("github_token");

const { generateContributionSnake } = await import(
"./generateContributionSnake"
Expand Down
4 changes: 3 additions & 1 deletion packages/demo/webpack.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import path from "path";
import HtmlWebpackPlugin from "html-webpack-plugin";
import webpack from "webpack";
import * as core from "@actions/core";
import { getGithubUserContribution } from "@snk/github-user-contribution";
import { config } from "dotenv";
import type { Configuration as WebpackConfiguration } from "webpack";
Expand All @@ -16,7 +17,8 @@ const webpackDevServerConfiguration: WebpackDevServerConfiguration = {
const userName: string = req.params.userName;
res.send(
await getGithubUserContribution(userName, {
githubToken: process.env.GITHUB_TOKEN!,
githubToken:
process.env.GITHUB_TOKEN ?? core.getInput("github_token"),
})
);
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as core from "@actions/core";
import { getGithubUserContribution } from "@snk/github-user-contribution";
import { VercelRequest, VercelResponse } from "@vercel/node";
import nodeFetch from "node-fetch";
Expand All @@ -12,7 +13,7 @@ export default async (req: VercelRequest, res: VercelResponse) => {
res.statusCode = 200;
res.json(
await getGithubUserContribution(userName as string, {
githubToken: process.env.GITHUB_TOKEN!,
githubToken: process.env.GITHUB_TOKEN ?? core.getInput("github_token"),
})
);
} catch (err) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
import * as core from "@actions/core";
import { getGithubUserContribution } from "..";
import { config } from "dotenv";
config({ path: __dirname + "/../../../.env" });

describe("getGithubUserContribution", () => {
const promise = getGithubUserContribution("platane", {
githubToken: process.env.GITHUB_TOKEN!,
githubToken: process.env.GITHUB_TOKEN ?? core.getInput("github_token"),
});

it("should resolve", async () => {
console.log(
"process.env.GITHUB_TOKEN",
process.env.GITHUB_TOKEN?.replace(/\d/g, "x")
);

await promise;
});

Expand Down
4 changes: 4 additions & 0 deletions svg-only/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ inputs:
github_user_name:
description: "github user name"
required: true
github_token:
description: "github token used to fetch the contribution calendar. Default to the action token if empty."
required: false
default: ${{ github.token }}
outputs:
required: false
default: null
Expand Down

0 comments on commit c9644d3

Please sign in to comment.