Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google postmaster improvement #11698

Merged
merged 5 commits into from May 2, 2024
Merged

Conversation

GTFalcao
Copy link
Collaborator

Adding an info box and an optional prop to control the "and/or" behavior of the Google Postmaster Tools API source.

Default behavior is being changed to 'or' instead of 'and', that is, the source will emit events if any of the configured props match (as opposed to requiring all of them).

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:16am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 2:16am
pipedream-docs ⬜️ Ignored (Inspect) Apr 30, 2024 2:16am

@GTFalcao GTFalcao added this to Ready for PR review in Component (Source and Action) Backlog Apr 30, 2024
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Apr 30, 2024
@luancazarine luancazarine moved this from Ready for PR review to In Review in Component (Source and Action) Backlog Apr 30, 2024
Copy link
Collaborator

@luancazarine luancazarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GTFalcao, thanks for your contribution! LGTM!

@luancazarine luancazarine moved this from In Review to Ready for QA in Component (Source and Action) Backlog Apr 30, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Google-postmaster-improvement-11698-a5a7f4c2d82b4931b4a6df409b243bc3

@GTFalcao GTFalcao merged commit 7ca92aa into master May 2, 2024
9 of 11 checks passed
@GTFalcao GTFalcao deleted the google-postmaster-improvement branch May 2, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants