Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: File Stores, improve $.files.dir() example #10458

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

NReilingh
Copy link
Contributor

WHAT

copilot:summary

copilot:poem

WHY

const dirs = $.files.dir() isn't good semantically. Nodes is more accurate.

HOW

copilot:walkthrough

const dirs = $.files.dir() isn't good semantically. Nodes is more accurate.
Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pipedream-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 1:29am
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 1:29am

Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michelle0927 michelle0927 moved this from Ready for PR review to Ready for QA in Component (Source and Action) Backlog Feb 19, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Feb 20, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog Feb 20, 2024
@vunguyenhung vunguyenhung merged commit dae3e38 into PipedreamHQ:master Feb 20, 2024
10 checks passed
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/docs-File-Stores-improve-files-dir-example-10458-9921c868979f4829916dd1c3e85f83fa

@michelle0927 michelle0927 moved this from Ready for release to Done in Component (Source and Action) Backlog Feb 20, 2024
luiidd pushed a commit to luiidd/pipedream that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee User submitted Submitted by a user
Development

Successfully merging this pull request may close these issues.

None yet

4 participants