Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Start using dark mode #48

Closed
wants to merge 1 commit into from

Conversation

andrejsharapov
Copy link
Contributor

I made a few changes to create a dark theme (feat #8). This is just an idea from a couple of mixins and variables, but I think it would be nice to start rethinking the use of colors directly in blocks and replace them with theme-specific variables:

// from
--white: #fff;
background-color: var(--white);
// to
--white: #fff;
 --bg-color: var(--white);
background-color: var(--bg-color);

So it will be possible to create not only dark and light, but also custom themes.

@andrejsharapov andrejsharapov changed the title Start using dark mode WIP: Start using dark mode Feb 3, 2023
@mririgoyen
Copy link
Member

mririgoyen commented Feb 3, 2023

I made a few changes to create a dark theme (feat #8). This is just an idea from a couple of mixins and variables, but I think it would be nice to start rethinking the use of colors directly in blocks and replace them with theme-specific variables:

// from
--white: #fff;
background-color: var(--white);
// to
--white: #fff;
 --bg-color: var(--white);
background-color: var(--bg-color);

So it will be possible to create not only dark and light, but also custom themes.

All colors should be in HSL format.

--white: 0deg 0% 100%;
background-color: hsl(var(--white));

This allows us to manipulate the base color without the need for a million variables. It also ensures the base color is consistent.

background-color: hsl(var(--white) / 50%);

I also have this mostly implemented already, hate to see you do a bunch of work for nothing. 😆

@andrejsharapov
Copy link
Contributor Author

I also have this mostly implemented already, hate to see you do a bunch of work for nothing.

In that case, I will close this PR)
p.s. for me, working with a website or icons is good practice, better than working on a pet-project. I like that you accept the ideas of other users, and also I get the unusual experience of "team" work 😄

@andrejsharapov andrejsharapov deleted the dark-theme branch February 5, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants