Static analysis improvements (#291)

* safer use of nullable domNode property * stan: improve types (level 6) * stan: run phpstan in level 6 mode
PhpGt · Sep 15, 2021 · cbe5a00 · cbe5a00
1 parent 14a6001
commit cbe5a00
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -64,3 +64,4 @@ jobs:
         uses: php-actions/phpstan@v2
         with:
           path: src/
+          level: 6
diff --git a/composer.lock b/composer.lock
diff --git a/src/ParentNode.php b/src/ParentNode.php
@@ -191,7 +191,7 @@ public function querySelector(string $selectors):?Element {
 	 * elements using selectors for more information about using selectors
 	 * to identify elements. Multiple selectors may be specified by
 	 * separating them using commas.
-	 * @return NodeList<Element> A non-live NodeList containing one Element
+	 * @return NodeList A non-live NodeList containing one Element
 	 * object for each descendant node that matches at least one of the
 	 * specified selectors.
 	 * @link https://developer.mozilla.org/en-US/docs/Web/API/ParentNode/querySelectorAll

diff --git a/test/phpunit/DocumentFragmentTest.php b/test/phpunit/DocumentFragmentTest.php
@@ -12,7 +12,6 @@ public function testGetElementByIdEmpty():void {
 	}
 
 	public function testGetElementById():void {
-		/** @var DocumentFragment $sut */
 		$sut = NodeTestFactory::createFragment();
 		$nodeWithId = $sut->ownerDocument->createElement("div");
 		$nodeWithId->id = "test";