Merge pull request #105 from PhpGt/102-nodelist

Return null when out of bounds

.gitignore

@@ -1,3 +1,3 @@
 /vendor
 /.idea
-/test/_coverage
+/test/unit/_coverage

src/NodeList.php

@@ -85,22 +85,11 @@ private function incrementKeyToNextElement() {
 	}
 
 // ArrayAccess -----------------------------------------------------------------
-
-	/**
-	 * Offset exists?
-	 * @param integer $offset offset number
-	 * @return boolean
-	 */
 	public function offsetExists($offset):bool {
 		return isset($offset, $this->domNodeList);
 	}
 
-	/**
-	 * Returns the element in the offset position
-	 * @param integer $offset offset number
-	 * @return Element
-	 */
-	public function offsetGet($offset):Element {
+	public function offsetGet($offset):?Element {
 		return $this->item($offset);
 	}
 
@@ -113,7 +102,6 @@ public function offsetUnset($offset) {
 	}
 
 // Countable -------------------------------------------------------------------
-
 	public function count():int {
 		return $this->length;
 	}

test/unit/NodeListTest.php

@@ -1,6 +1,7 @@
 <?php
 namespace Gt\Dom\Test;
 
+use Gt\Dom\Element;
 use Gt\Dom\HTMLDocument;
 use Gt\Dom\NodeList;
 use Gt\Dom\Test\Helper\Helper;
@@ -20,4 +21,19 @@ public function testNodeListFunctionsReturnGtObjects() {
 				"$key instance of " . gettype($object));
 		}
 	}
+
+	public function testNodeListIndexOutOfBounds() {
+		$document = new HTMLDocument(Helper::HTML_MORE);
+		$paragraphList = $document->getElementsByTagName("p");
+		$count = count($paragraphList);
+
+		for($i = 0; $i < $count; $i++) {
+			self::assertInstanceOf(
+				Element::class,
+				$paragraphList[$i]
+			);
+		}
+
+		self::assertNull($paragraphList[$count]);
+	}
 }