Fix gradient AGAIN. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix616
reviewed
Sep 20, 2023
| } | ||
| colors.put(e.getKey(), e.getValue()); | ||
| colors.add(new AbstractMap.SimpleEntry<>(e.getKey(), e.getValue())); |
There was a problem hiding this comment.
Pretty sure you can just add the entry directly into the colors list instead of creating a new entry as the entry values will never be modified.
There was a problem hiding this comment.
okay, shall I solve this?
|
Thanks for fixing that. You could've just pushed a new commit to the branch which fixed it (or amended your previous commit with the fix and force pushed if you wanted to only have one proper commit on that branch but usually just having a fixing commit is enough as you can squash all changes in the PR into one commit when merging anyways) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21
Sorry, I recreated a PR.
I'm still getting used to git.
Please recheck this.
(And if you can tell me what to do next time, that will be nice)