Fixes issue #4334 where zoomAndCenterAnimated did not center #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n coordinates. In static method AnimatedZoomJob:getInstance added the assignment of the parameters zoomCenterX, zoomCenterY, zoomOriginX, zoomOriginY.
a-bresler
approved these changes
Feb 1, 2024
|
While you wait for a merge (the last was 3 years ago), I merged it here already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
PR Description
Fixes issue with zoomAndCenterAnimated do not center but zooms to the start of the graph. See issue #4334
In static method AnimatedZoomJob:getInstance added the assignment of the parameters zoomCenterX, zoomCenterY, zoomOriginX, zoomOriginY.
This is a tiny fix to this excellent library. The solution was suggested 4 years ago but noone created a PR. Please merge so me and others don't have to compile from source.