Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BarLineChart-text-color #5423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BarLineChart-text-color #5423

wants to merge 1 commit into from

Conversation

ahmedbhd
Copy link

PR Checklist:

  • [✓] I have tested this extensively and it does not break any existing behavior.
  • [N/A] I have added/updated examples and tests for any new behavior.
  • [N/A] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

  • Minor code refactoring and minor ameliorations.
  • Remove unneeded WRITE_EXTERNAL_STORAGE permission.
  • Add change text color for BarLineChart.
  • Code refactoring to fix some lint warnings.
  • To support RTL configuration and be able to update text color of the BarLineChart.

PS: Since this project seems no longer supported, I've only tested the changes on the lib MPChartLib on a separate updated project.

- Add RTL support.
d1bfad7 
- Remove unneeded WRITE_EXTERNAL_STORAGE permission.
- Add change text color for BarLineChart.
- Code refactoring to fix some lint warnings.
@ahmedbhd ahmedbhd changed the title - Add RTL support. origin/BarLineChart-text-color Oct 17, 2023
@ahmedbhd ahmedbhd changed the title origin/BarLineChart-text-color BarLineChart-text-color Oct 17, 2023
@hannesa2
Copy link
Contributor

This repository is dead, so I applied almost the same changes here AppDevNext#174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmedbhd @hannesa2