Display highlighted entry values on the axes #5249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this library and using it in my apps, I would like to call people to continue with this awesome thing. I have forked the repo and started working on it! So I am ready as well to accept pull requests, I'll notify other people from here as well! Code is full kotlin now! Make your pull requests here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #222, Resolves #3879, Resolves #3872, Resolves #3669, Resolves #3550, Resolves #3352, Resolves #3269.
If y-axis uses the default value formater then the highlighted label value will be of the same precision as the normal labels.
Highlighted labels width is not taken into account when the longest label is calculated. That means if an y-axis highlighted label is longer than the normal labels it will get out of the axis bounds.
XAxis offsets computation has been moved from
Utils.drawXAxisValueinto a separate function to make it accessable toXAxisRender.drawHighlightLabels.Inspired by PR #4477.