Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IRC attribute to help error handling #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RduMarais
Copy link

@RduMarais RduMarais commented Dec 22, 2022

As mentioned in several issues, it would be nice to have a way to listen for the login failure.
In this PR I propose a very simple way to handle this : by adding an exception attribute to a chat.irc object, all users of the lib can listen for this attribute to be set with a TwitchChatError and raise this error.

This code does not conflict with the current state of the lib since it does not raise the Exception itself, but rather let the developpers listen for the event and raise or handle this themselves, therefore no compatibility issues.

This is follwowing the issue #32 (comment)

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant