Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to RecurringUserPlan.renewal_triggered_by #9

Closed
wants to merge 3 commits into from

Conversation

radekholy24
Copy link
Contributor

@radekholy24 radekholy24 commented Apr 2, 2024

@radekholy24 radekholy24 changed the title Do not use deprecated UserPlan.set_plan_renewal(has_automatic_renewal) add support for RecurringUserPlan.renewal_trigger Apr 3, 2024
@radekholy24 radekholy24 force-pushed the renewal_trigger branch 12 times, most recently from 7bf5bab to 07ec623 Compare April 5, 2024 12:23
@radekholy24 radekholy24 changed the title add support for RecurringUserPlan.renewal_trigger add support for RecurringUserPlan.renewal_triggered_by Apr 5, 2024
@radekholy24 radekholy24 changed the title add support for RecurringUserPlan.renewal_triggered_by migrate to RecurringUserPlan.renewal_triggered_by Apr 10, 2024
@radekholy24 radekholy24 changed the title migrate to RecurringUserPlan.renewal_triggered_by Migrate to RecurringUserPlan.renewal_triggered_by Apr 10, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.25%. Comparing base (20e46f9) to head (0df877f).
Report is 12 commits behind head on master.

❗ Current head 0df877f differs from pull request most recent head 4f46f43. Consider uploading reports for the commit 4f46f43 to get more accurate results

Files Patch % Lines
plans_payments/models.py 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   91.32%   90.25%   -1.08%     
==========================================
  Files          14       14              
  Lines         173      195      +22     
  Branches       17       27      +10     
==========================================
+ Hits          158      176      +18     
- Misses         11       13       +2     
- Partials        4        6       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PetrDlouhy
Copy link
Owner

@radekholy24 This should be now merged and released.

@PetrDlouhy PetrDlouhy closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants