Restore smartmatch overload hook #22612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed with the smartmatch removal, but I suspect it's better to silently leave it in for two reasons: Firstly, I suspect that there are lots of classes that overload several operators. Them having to conditionally set one of their overloads complicates them without much benefit. Silently allowing them seems like the friendliest option. If they're truly reliant on it the tests will show it anyway. Secondly, I am working on backwards compatability module, and that will require ~~ overloading one way or another. This would be easiest solution to that. The alternative would be to make the list of operators customizable, which may be good idea regardless of adding smartmatch back in.
haarg
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed with the smartmatch removal, but I suspect it's better to silently leave it in for two reasons:
Firstly, I suspect that there are lots of classes that overload several operators. Them having to conditionally set one of their overloads complicates them without much benefit. Silently allowing them seems like the friendliest option. If they're truly reliant on it the tests will show it anyway.
Secondly, I am working on backwards compatability module, and that will require
~~overloading one way or another. This would be easiest solution to that. The alternative would be to make the list of operators customizable, which may be good idea regardless of adding smartmatch back in.