Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qchem external demo #1132

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Update qchem external demo #1132

merged 6 commits into from
Jun 21, 2024

Conversation

soranjh
Copy link
Contributor

@soranjh soranjh commented Jun 17, 2024

The qchem demo on "Using PennyLane with PySCF and OpenFermion" is updated to use from_openfermion and to_openfermion functions.

[sc-66743]

Copy link

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

@soranjh soranjh marked this pull request as ready for review June 19, 2024 20:11
Copy link

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1132
  • Deployment SHA: f8611fdb8bc02dcd4a1956ba6825987d318e3854
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Contributor

@austingmhuang austingmhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @soranjh ! Just some small comments but nothing blocking.

demonstrations/tutorial_qchem_external.py Outdated Show resolved Hide resolved
demonstrations/tutorial_qchem_external.py Outdated Show resolved Hide resolved
demonstrations/tutorial_qchem_external.py Show resolved Hide resolved
@austingmhuang austingmhuang self-requested a review June 20, 2024 13:28
Copy link
Contributor

@ddhawan11 ddhawan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only one comment, can we link the documentation here as Austin suggested?

@soranjh soranjh requested a review from ddhawan11 June 20, 2024 20:11
@soranjh soranjh merged commit f499f66 into dev Jun 21, 2024
10 checks passed
@soranjh soranjh deleted the openfermion_pl_conversion branch June 21, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants