-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [g-sim 3] (g + P)-sim #1118
Conversation
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
In the end I managed to combine both approaches into one, as they are effectlvely the same. The branching one is nice to understand the underlying transformations and the required maximum moment order. The g-sim in moment vector spaces approach is more practical and what one would do in the end, though I finally argue based on some scaling numbers that this approach is overall of limited practical utility and should be understood as a mere theoretical insight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you made this work, and in two ways, even! Congrats for this nice work @Qottmann 💯
Very nice and concise read, really liked it.
I left a number of comments, as usual a good bit of them are subjective suggestions.
Regarding the direction of the drawings: I think reverting it might actually be a good idea. However, I think it should be consistent with the other demo, and as the depicted matrices/tensors are not a circuit diagram directly, it might be useful to have this visual differentiation. Also, the current ordering works with matrix product notation, which is nice :) So I think both directions have their perks.
"dateOfLastModification": "2024-06-30T00:00:00+00:00", | ||
"categories": [ | ||
"Quantum Computing", | ||
"Getting Started" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this demo is for beginners? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, definitely not 😆 The metadata is actually just a copy-paste from the liesim demo, I need to still update that but figured this is lowest priority atm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the updates! 🎉 Sorry to keep you waiting but I'd like to do one more math-only pass before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took another look and I'm comfortable with the second approach now as well :)
Really well done pulling this one off 💯 It's definitely a funky mathematical foundation to walk on! :o
Just had some tiny additional comments, including one typo for math mode.
Remember to update metadata before merging 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the metadata together with the thumbnail
A note: I found some inconsistency in gate nomenclature — it would be worth it to check that the P gate is consistently capitalized and in mathcal or not.
The mathcal
Also, why is it called tutorial_liesim3? I assume this is for historical reasons; it might be better to pick something different (_extension)?
Good point! Will update the file names 👍
demonstrations/tutorial_liesim3.py
Outdated
@@ -0,0 +1,568 @@ | |||
r"""(g + P)-sim: Extending g-sim by non-DLA observables and gates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the website handle that? I removed all inline math from headings for this demo due to the rendering issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Qottmann .
Two items remain:
- I'll look into fixing the rendering issue in the first note.
- If you could check if the demo title would display correctly if math-mode is used within it, that would be great. This issue in section titles was fixed recently.
.. note:: | ||
|
||
The contents of this demo are self-contained. However, familiarity with | ||
:doc:`dynamical Lie algebras </demos/tutorial_liealgebra>` and :doc:`:math:`\mathfrak{g}`-sim in PennyLane </demos/tutorial_liesim>` are advised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think I've seen this before, just gonna remove the mathmode from the link 🙃
Co-authored-by: Ivana Kurečić <[email protected]>
Merged the approach from #1106 with the branching approach here. This has neater illustrations anyway 👍
If you are writing a demonstration, please answer these questions to facilitate the marketing process.
GOALS — Why are we working on this now?
Lie algebras in QC and simulation techniques like g-sim are a hot topic due to their relevance to barren plateaus. This is an extension of g-sim to a small number of non-DLA gates. It bears some intriguing theoretical features but, like g-sim itself, is of rather limited practical relevance.
AUDIENCE — Who is this for?
This is an expert demo targeted towards people familiar with Lie algebras, g-sim in particular.
KEYWORDS — What words should be included in the marketing post?
Which of the following types of documentation is most similar to your file?
(more details here)
[sc-62859]