Update actions using old Node version #1111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidnhm
previously requested changes
May 21, 2024
doctorperceptron
added
the
ci:build-all-qml-demos
doctorperceptron
changed the title
|
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
|
@rashidnhm this is ready for another look. See the note above about the upload/download artifact actions. May need you to tackle those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of our old actions use Node 16, which is deprecated in GitHub Actions. Bumping:
actions/checkoutto v4actions/setup-pythonto v5actions/changed-filesto v44actions/cacheto v3.2.2 (latest)I have not bumped
actions/upload-artifactoractions/download-artifactas v4 has breaking API changes and I will definitely mess that up.