feat: remove sso without emailing all users #10608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Good enough. Removing the auth identity will count towards their daily password reset limit of 3, even though they will not get the email, but that shouldn't be an issue.
Interestingly, the one who does this operation will not be able to reset their own password if more than 5 people were affected. That's already the case on master.
|
Thanks for looking into those edge cases! I'll merge this, ship to prod, and run this for the org mentioned in the Slack thread |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10607