Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve reflection group titles #10546

Merged
merged 8 commits into from
Dec 10, 2024
Merged

feat: improve reflection group titles #10546

merged 8 commits into from
Dec 10, 2024

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Dec 3, 2024 •
edited
Loading

Fix #10532

Demo: https://www.loom.com/share/5ab047ccb3394b38a395fc64511de1fa?sid=2c6b5610-7b8d-49ea-ac3c-563453b7a8f9

This PR does not include:

To test

  • With AI features enabled, group & ungroup reflections and see the new ChatGPT group titles
  • With AI features disabled, see the behaviour that currently exists in prod

@github-actions github-actions bot added the size/m label Dec 3, 2024
@nickoferrall nickoferrall mentioned this pull request Dec 4, 2024
Closed
1 task
@nickoferrall nickoferrall mentioned this pull request Dec 4, 2024
Open
1 task
@nickoferrall nickoferrall marked this pull request as ready for review December 4, 2024 16:10
@nickoferrall nickoferrall mentioned this pull request Dec 4, 2024
Open
1 task
mattkrick
mattkrick approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mattkrick mattkrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/server/graphql/mutations/helpers/generateAIGroupTitle.ts
{
meetingId,
reflectionGroupId,
title: aiTitle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be newTitle?

@nickoferrall nickoferrall merged commit cfde723 into master Dec 10, 2024
6 checks passed
@nickoferrall nickoferrall deleted the feat/10532/improve-group-titles branch December 10, 2024 11:45
@parabol-release-bot parabol-release-bot bot mentioned this pull request Dec 10, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkrick mattkrick mattkrick approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve reflection group titles
2 participants
@nickoferrall @mattkrick